Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cubes as input for bias preprocessor #2183

Merged
merged 17 commits into from
Jan 23, 2024
Merged

Allow cubes as input for bias preprocessor #2183

merged 17 commits into from
Jan 23, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Aug 28, 2023

Description

This PR allows using cubes as input for the bias preprocessor, which drastically increases its usability outside of recipes. Additionally, I added a check if the bias_type argument is valid that is executed much earlier before processing datasets.

Closes #2082

Link to documentation: https://esmvaltool--2183.org.readthedocs.build/projects/ESMValCore/en/2183/recipe/preprocessor.html#bias


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the preprocessor Related to the preprocessor label Aug 28, 2023
@schlunma schlunma added this to the v2.10.0 milestone Aug 28, 2023
@schlunma schlunma self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0668223) 93.72% compared to head (a4dc385) 93.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2183      +/-   ##
==========================================
+ Coverage   93.72%   93.74%   +0.01%     
==========================================
  Files         238      238              
  Lines       13125    13153      +28     
==========================================
+ Hits        12302    12330      +28     
  Misses        823      823              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlunma schlunma modified the milestones: v2.10.0, v2.11.0 Oct 2, 2023
@valeriupredoi
Copy link
Contributor

I'll have a review done tomorrow, bud

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking very good, and cheers, Manu! The two reasons why I'm not approving straightaway are that error that I think needs be a bit more explicit, and (for the life of me) I can't see how those two integration tests differ 🍺

doc/recipe/preprocessor.rst Show resolved Hide resolved
doc/recipe/preprocessor.rst Show resolved Hide resolved
esmvalcore/preprocessor/_bias.py Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_bias.py Show resolved Hide resolved
tests/integration/recipe/test_recipe.py Show resolved Hide resolved
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks for addressing the review points, bud 🍺

@schlunma
Copy link
Contributor Author

Thanks for the review V! Merging this now since I need it to continue with #2299.

@schlunma schlunma merged commit 989839f into main Jan 23, 2024
4 checks passed
@schlunma schlunma deleted the better_bias branch January 23, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bias preprocessor work with cubes
2 participants