-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cubes as input for bias
preprocessor
#2183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2183 +/- ##
==========================================
+ Coverage 93.72% 93.74% +0.01%
==========================================
Files 238 238
Lines 13125 13153 +28
==========================================
+ Hits 12302 12330 +28
Misses 823 823 ☔ View full report in Codecov by Sentry. |
I'll have a review done tomorrow, bud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking very good, and cheers, Manu! The two reasons why I'm not approving straightaway are that error that I think needs be a bit more explicit, and (for the life of me) I can't see how those two integration tests differ 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks for addressing the review points, bud 🍺
Thanks for the review V! Merging this now since I need it to continue with #2299. |
Description
This PR allows using cubes as input for the bias preprocessor, which drastically increases its usability outside of recipes. Additionally, I added a check if the
bias_type
argument is valid that is executed much earlier before processing datasets.Closes #2082
Link to documentation: https://esmvaltool--2183.org.readthedocs.build/projects/ESMValCore/en/2183/recipe/preprocessor.html#bias
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: