Fix derivation for sea ice extent (siextent) #2648
Open
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloosvel
reviewed
Jan 30, 2025
| @@ -48,16 +49,19 @@ def calculate(cubes): | |||
| sic = cubes.extract_cube(Constraint(name="sic")) | |||
| except iris.exceptions.ConstraintMismatchError: | |||
| try: | |||
| sic = cubes.extract_cube(Constraint(name="siconca")) | |||
There was a problem hiding this comment.
If I remember correctly, siconca was added because some models were missing siconc, but I am not sure if that is still the case.
There was a problem hiding this comment.
That is right. In any case, I think it does not hurt to also try "siconca", so I would prefer to keep this here if that's fine.
There was a problem hiding this comment.
Well in that case, it looks like it needs to be re-added because tests are failing due to siconca not being required anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes some small issues with the derivation script for sea ice extent, i.e.
This fix is required for calculating and plotting a correct seasonal cycle of Arctic/Antarctic sea ice extent for REF: ESMValGroup/ESMValTool#3891