Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dask #2654

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Pin dask #2654

merged 5 commits into from
Feb 10, 2025

Conversation

sloosvel
Copy link
Contributor

@sloosvel sloosvel commented Feb 7, 2025

Description

As discussed in #2607 (comment)
Related to #2607


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@sloosvel sloosvel added the installation Installation problem label Feb 7, 2025
@sloosvel sloosvel added this to the v2.12.0 milestone Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (9aadaca) to head (91b2648).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2654   +/-   ##
=======================================
  Coverage   95.06%   95.07%           
=======================================
  Files         255      255           
  Lines       14884    14884           
=======================================
+ Hits        14150    14151    +1     
+ Misses        734      733    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @sloosvel - let's pin in the way @bouweandela suggested to allow for some wiggle room for older dasks. Also, could you pls pop the pin in pyroject.toml as well? 🍺

environment.yml Outdated Show resolved Hide resolved
Co-authored-by: Valeriu Predoi <[email protected]>
@sloosvel
Copy link
Contributor Author

sloosvel commented Feb 7, 2025

That broke the installation:

PackagesNotFoundError: The following packages are not available from current channels:

  • dask[version='<2024.8,>=2025']

@valeriupredoi
Copy link
Contributor

eugh silly solver! Shall we just ">=2025" then? @bouweandela @schlunma - what you folks reckon? I found this to be a solid pin, and we get rid of all the crap that came after 2024.8

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we good this way @sloosvel - the env picks up iris==3.11.0 which is fine until iris fix their blocking in 3.11.2 or 3.12 (3.11.1 was released mostly only for the retropin on Dask anyway) 🍺

@sloosvel
Copy link
Contributor Author

sloosvel commented Feb 10, 2025

Thanks @valeriupredoi ! By the way, do you know why the tests are failing for Python 3.10?

@valeriupredoi
Copy link
Contributor

Thanks @valeriupredoi ! By the way, do you know why the tests are failing for Python 3.10?

where?

@sloosvel
Copy link
Contributor Author

In the main branch. A few days ago, the Python 3.12 installation was failing but now it's the Python 3.10 one.

@valeriupredoi
Copy link
Contributor

lemme have a look - nightlies were fine when I checked an hour ago

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Feb 10, 2025

ah this one - setup-miniconda is using an old mamba that's causing transient fails, see conda-incubator/setup-miniconda#392 - nothing a rerun can't solve though 😁 That's actually a good point for the release, it could be they won't update the base mamba by then, so expect some of this guff 👍

@sloosvel sloosvel merged commit c3a2b6c into main Feb 10, 2025
7 checks passed
@sloosvel sloosvel deleted the pin_dask branch February 10, 2025 13:47
@sloosvel sloosvel mentioned this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants