-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin dask #2654
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2654 +/- ##
=======================================
Coverage 95.06% 95.07%
=======================================
Files 255 255
Lines 14884 14884
=======================================
+ Hits 14150 14151 +1
+ Misses 734 733 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks @sloosvel - let's pin in the way @bouweandela suggested to allow for some wiggle room for older dasks. Also, could you pls pop the pin in pyroject.toml
as well? 🍺
Co-authored-by: Valeriu Predoi <[email protected]>
That broke the installation: PackagesNotFoundError: The following packages are not available from current channels:
|
eugh silly solver! Shall we just ">=2025" then? @bouweandela @schlunma - what you folks reckon? I found this to be a solid pin, and we get rid of all the crap that came after 2024.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we good this way @sloosvel - the env picks up iris==3.11.0 which is fine until iris fix their blocking in 3.11.2 or 3.12 (3.11.1 was released mostly only for the retropin on Dask anyway) 🍺
Thanks @valeriupredoi ! By the way, do you know why the tests are failing for Python 3.10? |
where? |
In the main branch. A few days ago, the Python 3.12 installation was failing but now it's the Python 3.10 one. |
lemme have a look - nightlies were fine when I checked an hour ago |
ah this one - setup-miniconda is using an old |
Description
As discussed in #2607 (comment)
Related to #2607
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: