PV capacity factor for ESMValTool GMD paper

[katjaweigel]

Description

PV capacity factor described in GMD paper https://gmd.copernicus.org/preprints/gmd-2020-244/

• Closes PV capacity factor for ESMValTool GMD paper  #2157
• Link to documentation: https://github.com/ESMValGroup/ESMValTool/blob/pvcf_gmddraft/doc/sphinx/source/recipes/recipe_pv_capacity_factor.rst

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[katjaweigel]

Documentation is still missing and provenance needs to be checked/added.

[remi-kazeroni]

Hi @katjaweigel, thanks for your nice work here! I did a technical review and left some comments about styling and documentation. I'm not fluent in R but your scripts look good to me. Feel free to take into account the styling issues I found.

Nevertheless, I can't mark this PR approved because I couldn't run the recipe with the latest ESMValCore 2.3.0. I got an issue with the multi_model_statistics (see log attached).

@zklaus: even though this PR is not yet in the main branch, would this count as another test of the ESMValCore 2.3.0 like in #2198?
main_log_debug.txt

[katjaweigel]

Dear @remi-kazeroni thanks for your comments and corrections! I'll go through them and test, what happens if I run it with the currents Core and if I can help to solve this.

[zklaus]

@zklaus: even though this PR is not yet in the main branch, would this count as another test of the ESMValCore 2.3.0 like in #2198?
main_log_debug.txt

Sure! Though if it doesn't make its way into ESMValTool 2.3.0 and requires some change to the core that doesn't impact anything else, that change might be relegated to ESMValCore 2.4.0.

[zklaus]

That said, @remi-kazeroni, if you think the changes needed in this PR are relatively minor, feel free to assign milestone 2.3.0 and we'll do our best to get it in.

[katjaweigel]

@remi-kazeroni sorry, I didn't see the other ones, they were hidden behind some button "Hidden conversions" and I thought it would only hide resolved one. I'll look at them soon (need to leave soon, so I guess I can't finish it now).

[katjaweigel]

@remi-kazeroni sorry, I didn't see the other ones, they were hidden behind some button "Hidden conversions" and I thought it would only hide resolved one. I'll look at them soon (need to leave soon, so I guess I can't finish it now).

@remi-kazeroni I hope I found and corrected everything this time.

[remi-kazeroni]

Thanks @katjaweigel! Everything looks good to me now from the technical side 👍

[Emmadd]

Hi, I'll try to review this request, but it might be a bit difficult to get input data to actually run the recipe locally. @remi-kazeroni is the output of your successful run somewhere, so I can see that instead?

[katjaweigel]

Hi, I'll try to review this request, but it might be a bit difficult to get input data to actually run the recipe locally. @remi-kazeroni is the output of your successful run somewhere, so I can see that instead?

@Emmadd thanks for reviewing! Due to the discussion about the multi-model mean for daily data I'll completely remove it for the moment. Without multi-model mean the recipe should actually run on any data set which contains the variables tas and rsds (many CMIP5 or 6 models, ERA-Interim). I ran it on Mistral, if you can access this, the latest output with the setting above is at:
/work/bd1083/b380216/output/recipe_pv_capacity_factor_20210629_071411

/work/bd1083/b380216/output/recipe_pv_capacity_factor_20210707_075819/ with most recent changes.

[Emmadd]

@esmvalbot please run recipe_pv_capacity_factor.yml

[esmvalbot]

Since @Emmadd asked, ESMValBot will run recipe recipe_pv_capacity_factor.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is happy to report recipe recipe_pv_capacity_factor.yml ran OK, output has been generated here

[Emmadd]

Hi, the code looks ok to me. A few things confused me where wind is (still) mentioned, I would like to see those addressed. ESMValbot was able to run the recipe, but I haven't been able to see and compare the figure(s). Best, Emma

[katjaweigel]

Hi, the code looks ok to me. A few things confused me where wind is (still) mentioned, I would like to see those addressed. ESMValbot was able to run the recipe, but I haven't been able to see and compare the figure(s). Best, Emma

@ thanks @Emmadd ! The figures are there: https://esmvaltool.cloud.dkrz.de/shared/esmvaltool/esmvalbot-output/pvcf_gmddraft-kr0c7llt/recipe_pv_capacity_factor_20210712_081803/plots/capacity_factor/main/
This really should be improved that this link is not given on the esmvalbot output page but one needs to put it together from its link and the main_log.txt

[Emmadd]

Figures look fine!

[katjaweigel]

@Emmadd I tried to address all points you wrote in the review, can you check if this is ok now?
The main partly open points are, if I should show a model and an ERA-Interim Figure in the docu and if it is more important to keep the path name as in the paper or the consistency between the path and the recipe/diagnostic?

[Emmadd]

Hi @katjaweigel changes look good to me. It's fine to stick with the IPSL figure. As for the path name I'd prefer consistency between the recipe/diagnostic, but that's just my humble opinion.