Remove model AWI-CM-1-1-MR from recipe_impact.yml #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esmvalbot Please run recipe_impact.yml |
|
Since @bouweandela asked, ESMValBot will run recipe recipe_impact.yml as soon as possible, output will be generated here |
|
ESMValBot is happy to report recipe recipe_impact.yml ran OK, output has been generated here |
bouweandela
changed the title
Peter9192
approved these changes
Jul 20, 2021
|
People tend not to like models being removed, so maybe we should add an issue to re-add the model soon. I also wonder: Do we really get areacello added to an atmosphere variable? If so, that seems like a bug worthy of its own issue as well. |
|
For future reference, also note #2198 (comment) |
Issue created: ESMValGroup/ESMValCore#1265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recipe
recipe_impact.ymlfails to run with the latest release of ESMValCore (v2.3.0), see #2198 (comment), because the CMOR check for the AWI-CM-1-1-MR model fails, see ESMValGroup/ESMValCore#751. I suspect the CMOR check failure is for the areacello cell measure, which probably shouldn't be added to air_temperature for thearea_statisticspreprocessor anyway, because it is on a different grid. This pull request works around the problem by removing the AWI dataset from the recipe.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: