Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues #276 #278 #296 #297 #308

Merged
merged 12 commits into from
Feb 12, 2024
Merged

Fixing issues #276 #278 #296 #297 #308

merged 12 commits into from
Feb 12, 2024

Conversation

gulcing
Copy link

@gulcing gulcing commented Feb 1, 2024

Pull Request checklist

Before you start

  • Read CONTRIBUTING.md.
  • Create an issue to discuss your idea. This allows your contributions to be incorporated into the tutorial.

Tasks

  • Give this pull request a descriptive title.
  • If you are contributing to existing lesson materials, please make sure the content conforms to the Lesson development section in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • If you are making a new episode, please make sure the content conforms to the Lesson organization and Lesson formatting sections in CONTRIBUTING.md and does not contain any spelling or grammatical errors.
  • Preferably Codacy checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why.
  • Preview changes on your machine before pushing them to GitHub by running make serve, alternatively make docker-serve. Please see the Previewing your changes locally section in CONTRIBUTING.md for installation instructions.
  • All code instructions have been tested.

Closes #276, closes #278, closes #296, closes #297

@gulcing gulcing requested a review from LisaBock February 1, 2024 09:58
@gulcing gulcing marked this pull request as ready for review February 1, 2024 09:58
Copy link
Contributor

@LisaBock LisaBock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gulcing ! Looks fine.

After deleting the file _episodes/.10-debugging.md.swp from the PR this could be merged.

@LisaBock
Copy link
Contributor

Thanks again @gulcing !

@LisaBock LisaBock merged commit 30a6420 into main Feb 12, 2024
1 check passed
@LisaBock LisaBock deleted the fix_issue_jan branch February 12, 2024 07:57
ehogan pushed a commit to ehogan/ESMValTool_Tutorial that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment