Neo Integration #124
Open
Neo Integration #124
+975
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to resolve the merge conflicts & test this, I rebased the branch as william/rebased-neo-plugin. I also had to create a matching GUI branch at william/add-neo to actually be able to use this plugin. When I run the plugin on those branches, my wallet does not display a balance even though it has funds. The error I see in the console is |
Open
|
@swansontec can you please try #154 ? We have fixed the issue that you mentioned above. |
peachbits
requested changes
Aug 10, 2020
| @@ -0,0 +1,47 @@ | |||
| export const NeoTransactonOnline = { | |||
There was a problem hiding this comment.
Typo in the variable name is causing tests to fail. Should be 'NeoTransactionOnline'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly I referred codes from other assets integration and it may have mistakes.
I have written the UT and it passed