Harden ripple api connectivity #906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
reviewed
Mar 14, 2025
| @@ -87,22 +92,28 @@ export class RippleTools implements EdgeCurrencyTools { | |||
|
|
|||
| async connectApi(walletId: string): Promise<void> { | |||
| if (Object.keys(this.rippleApiSubscribers).length === 0) { | |||
| this.rippleApiSubscribers[walletId] = true | |||
There was a problem hiding this comment.
I feel like this should be a Set instead of an object, but maybe that's out of scope for this PR.
src/ripple/RippleTools.ts
Outdated
| await api.connect() | ||
| return api | ||
| }) | ||
| const result: Client = await asyncWaterfall(funcs) |
There was a problem hiding this comment.
Do we want to reset the promise / resolver here too?
peachbits
force-pushed
the
matthew/xrp-reconnect
branch
from
8a351e8 to
5233ae9
Compare
swansontec
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none