Fix styling in QrCode #5483
Merged
Fix styling in QrCode #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/fix/qr-modal-icon
branch
2 times, most recently
from
696d9ea to
3392fd7
Compare
swansontec
approved these changes
Mar 5, 2025
src/components/themed/QrCode.tsx
Outdated
| justifyContent: 'center', | ||
| left: '50%', | ||
| top: '50%', | ||
| transform: [{ translateX: -iconContainerSize / 2 }, { translateY: -iconContainerSize / 2 }] |
There was a problem hiding this comment.
Optional: The transform may not be the most efficient option. You could also do it this way:
marginLeft: -iconContainerSize / 2,
marginTop: -iconContainerSize / 2This will move the container up & to the left by half it's width, allowing left: '50%' and top: '50%' to correctly center it. It's very similar to the transform you have, but it happens at the layout stage instead of the rendering phase, which is generally perferable.
Jon-edge
force-pushed
the
jon/fix/qr-modal-icon
branch
from
3392fd7 to
8064f5b
Compare
- Removed existing styling hack for the QR code itself, which then fixes the crypto icon positioning - Changed to a dynamically calculated icon size to retain size ratios across device sizes
Jon-edge
force-pushed
the
jon/fix/qr-modal-icon
branch
from
8064f5b to
0913d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: