Fix numeric input mode for FilledTextInput #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Mar 13, 2025
swansontec
force-pushed
the
william/fix-numeric-filled-input
branch
from
f3984c0 to
6b907b7
Compare
samholmes
approved these changes
Mar 13, 2025
The `FilledTextInput` component was relying on a child component to handle its number formatting, but that component is incompatible with our new semi-controlled approach. Just use the intl utility functions to provide the same behavior directly.
swansontec
force-pushed
the
william/fix-numeric-filled-input
branch
from
6b907b7 to
b92b78d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FilledTextInputcomponent was relying on a child component to handle its number formatting, but that component is incompatible with our new semi-controlled approach. Just use the intl utility functions to provide the same behavior directly.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: