Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to pass name attribute to Select component #937

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Adpearance
Copy link
Contributor

@Adpearance Adpearance commented Feb 21, 2019

Allows name attribute to be set correctly, following the same method as other Input elements.

Please makes sure these boxes are checked before submitting your PR, thank you!

  • [X ] Make sure you are merging your commits to master branch.
  • [X ] Add some descriptions and refer relative issues for you PR.
  • [X ] Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • Removes the static name:'name' from the component and replaces it with dynamic values to properly set a component name.

Allows name attribute to be set correctly, following the same method as other Input elements.
Copy link
Contributor

@hazel54 hazel54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not neccessary to put "name" attribute in state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants