Update spirv-tools #1127
Merged
Update spirv-tools #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jake-Shadle
commented
Feb 5, 2024
Jake-Shadle
commented
- Update to spirv-tools 0.10.0
- Use pre-built binaries from spirv-tools-rs
eddyb
suggested changes
Feb 5, 2024
There was a problem hiding this comment.
Mostly just the Cargo.toml nitpick, but you also need to add a changelog entry, can you make sure to mention "Vulkan SDK 1.3.275" as well in it?
(I want to be more cognizant of specific Vulkan SDK versions just so as much as possible can be kept in sync without having to guess or approximate etc.)
Jake-Shadle
force-pushed
the
update-spirv-tools
branch
from
a2b1843
to
d18533f
Compare
eddyb
suggested changes
Feb 7, 2024
eddyb
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.