Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-ui/page-drawer): Added bgColor and slots optional props #259

Open
wants to merge 3 commits into
base: stage
Choose a base branch
from
Open

feat(react-ui/page-drawer): Added bgColor and slots optional props #259

wants to merge 3 commits into from

Conversation

DorijanH
Copy link
Member

@DorijanH DorijanH commented Dec 22, 2023 •
edited
Loading

Added

  • .changelog.json config file to the react-ui package
  • [PageDrawer] bgColor and slots optional props

@DorijanH DorijanH changed the title feat(react-ui/page-drawer): Added bgColor and rootSx optional props feat(react-ui/page-drawer): Added bgColor and slots optional props Dec 22, 2023
AleksandarDev
AleksandarDev reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@AleksandarDev AleksandarDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this opens up component for too much customization. Can you provide example of when this would be used?

@AleksandarDev AleksandarDev deleted the branch stage January 4, 2024 10:27
@AleksandarDev AleksandarDev reopened this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksandarDev AleksandarDev AleksandarDev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DorijanH @AleksandarDev