publishers: remove hearsay about logger construction order

The C++ standard specifies that all objects in the same translation unit
(i.e. source file) are constructed in order of declaration. Since this is
the most common case when using Modular Sensors, the described case cannot
occur.

src/dataPublisherBase.h

@@ -87,12 +87,6 @@ class dataPublisher {
      * @param baseLogger The logger supplying the data to be published
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. Not respected by all publishers.
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     explicit dataPublisher(Logger& baseLogger, int sendEveryX = 1);
     /**
@@ -104,12 +98,6 @@ class dataPublisher {
      * single TinyGSM modem instance
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. Not respected by all publishers.
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     dataPublisher(Logger& baseLogger, Client* inClient, int sendEveryX = 1);
     /**
@@ -148,13 +136,7 @@ class dataPublisher {
      * @brief Begin the publisher - linking it to the client and logger.
      *
      * This can be used as an alternative to adding the logger and client in the
-     * constructor.  This is slightly "safer" because we expect the publishers
-     * to be created in the "global scope" and we cannot control the order in
-     * which objects in that global scope will be created.  That is, we cannot
-     * guarantee that the logger will actually be created before the publisher
-     * that wants to attach to it unless we wait to attach the publisher until
-     * in the setup or loop function of the main program.  In reality, it is
-     * very unlikely that this is necessary.
+     * constructor.
      *
      * @param baseLogger The logger supplying the data to be published
      * @param inClient An Arduino client instance to use to print data to.
@@ -172,13 +154,7 @@ class dataPublisher {
      * logger.
      *
      * This can be used as an alternative to adding the logger and client in the
-     * constructor.  This is slightly "safer" because we expect the publishers
-     * to be created in the "global scope" and we cannot control the order in
-     * which objects in that global scope will be created.  That is, we cannot
-     * guarantee that the logger will actually be created before the publisher
-     * that wants to attach to it unless we wait to attach the publisher until
-     * in the setup or loop function of the main program.  In reality, it is
-     * very unlikely that this is necessary.
+     * constructor.
      *
      * @param baseLogger The logger supplying the data to be published
      */

src/publishers/DreamHostPublisher.h

@@ -53,12 +53,6 @@ class DreamHostPublisher : public dataPublisher {
      * @param baseLogger The logger supplying the data to be published
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     explicit DreamHostPublisher(Logger& baseLogger, int sendEveryX = 1);
     /**
@@ -70,12 +64,6 @@ class DreamHostPublisher : public dataPublisher {
      * single TinyGSM modem instance
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     DreamHostPublisher(Logger& baseLogger, Client* inClient,
                        int sendEveryX = 1);

src/publishers/EnviroDIYPublisher.h

@@ -53,12 +53,6 @@ class EnviroDIYPublisher : public dataPublisher {
      * @param baseLogger The logger supplying the data to be published
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     explicit EnviroDIYPublisher(Logger& baseLogger, int sendEveryX = 1);
     /**
@@ -70,12 +64,6 @@ class EnviroDIYPublisher : public dataPublisher {
      * single TinyGSM modem instance
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     EnviroDIYPublisher(Logger& baseLogger, Client* inClient,
                        int sendEveryX = 1);

src/publishers/ThingSpeakPublisher.h

@@ -78,12 +78,6 @@ class ThingSpeakPublisher : public dataPublisher {
      * @param baseLogger The logger supplying the data to be published
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     explicit ThingSpeakPublisher(Logger& baseLogger, int sendEveryX = 1);
     /**
@@ -95,12 +89,6 @@ class ThingSpeakPublisher : public dataPublisher {
      * single TinyGSM modem instance
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     ThingSpeakPublisher(Logger& baseLogger, Client* inClient,
                         int sendEveryX = 1);

src/publishers/UbidotsPublisher.h

@@ -52,12 +52,6 @@ class UbidotsPublisher : public dataPublisher {
      * @param baseLogger The logger supplying the data to be published
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     explicit UbidotsPublisher(Logger& baseLogger, int sendEveryX = 1);
     /**
@@ -69,12 +63,6 @@ class UbidotsPublisher : public dataPublisher {
      * single TinyGSM modem instance
      * @param sendEveryX Interval (in units of the logging interval) between
      * attempted data transmissions. NOTE: not implemented by this publisher!
-     *
-     * @note It is possible (though very unlikey) that using this constructor
-     * could cause errors if the compiler attempts to initialize the publisher
-     * instance before the logger instance.  If you suspect you are seeing that
-     * issue, use the null constructor and a populated begin(...) within your
-     * set-up function.
      */
     UbidotsPublisher(Logger& baseLogger, Client* inClient, int sendEveryX = 1);
     /**