-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.13.2 support #11
base: dev/1.6
Are you sure you want to change the base?
Conversation
I have even added partial 1.7.10 support now: https://github.com/ThexXTURBOXx/architectury-loom/tree/dev/1.6-1.7.10 As a workaround (to test the current 1.7.10 configuration), one can add |
I have finally fixed the issue, but the approach became way more hacky than I would like it to be: ThexXTURBOXx/architectury-loom@dev/1.6...ThexXTURBOXx:architectury-loom:dev/1.6-1.7.10 Edit: At least I can verify that my branch also works fine in my CI/CD configuration! |
Rebased on upstream |
First of all: Thank you very much for this fork of architectury-loom!
However, I have found a few issues related to 1.13.2 - it just did not want to work properly.
After some tinkering around with various configurations, I found the culprits:
For this to work, the new implementation relies on the
spec
version (for some older Forge 1.13.2 versions we need to hack it to2
, though).Furthermore, during this whole process I found that the LZMA files that are being generated by legacy configurations are "damaged" - this is due to ning/jvm-compressor-benchmark#1, which is referenced in jponge/lzma-java#9.
Since
org.tukaani:xz:1.8
was already a (probably runtime (?)) dependency, I removedlzma-java
and migrated the code toxz
, which does not have any issues with silenced OOMs anymore.