Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sponsor main page #1010

Open
wants to merge 63 commits into
base: ep2025
Choose a base branch
from
Open

Add sponsor main page #1010

wants to merge 63 commits into from

Conversation

hypha
Copy link
Contributor

@hypha hypha commented Feb 14, 2025

  • changed the main sponsor page with 2025 content
  • packages styling and responsive
  • Highlight stats component
  • packages tables final pass
  • packages pdf link undefined
  • early bird undefined
  • add-ons needs review
  • commented out OSS is it is probably not going to be included on this page
  • converted the sponsor-tiers to astro component (and added a ribbon one to separate out the svg). Not sure if it is a good idea.
  • fixed ribbon styling overlapping with text
  • merge Add disabled prop to ButtonLink #1008 into this due to syntax change for buttons.
  • add to menu
  • update faq (milestone and early bird date undefined)
  • change sponsor-tiers signup form from undefined to real link
  • add volume discount (not needed until after ticket launch)
  • add cta

@hypha hypha marked this pull request as draft February 14, 2025 13:15
Copy link
Contributor

github-actions bot commented Feb 14, 2025

Preview available

Key Value
url https://ep2025-sponsorship.ep-preview.click
last update 2025-03-09T21:15:11.147Z

@hypha
Copy link
Contributor Author

hypha commented Feb 14, 2025

@egeakman I don't know if the component and styling changes make any sense. Would you mind taking a look when you have the time before all the content is ready from the team?

@egeakman
Copy link
Member

@hypha I think it looks great! The ribbon placement looks better than last year I think. And huuuuuuge hugs 🤗 for converting the sponsor components to Astro!

@hypha hypha force-pushed the ep2025-sponsorship branch from 968bcda to 1ee573e Compare February 17, 2025 12:28
@hypha
Copy link
Contributor Author

hypha commented Feb 17, 2025

@hypha I think it looks great! The ribbon placement looks better than last year I think. And huuuuuuge hugs 🤗 for converting the sponsor components to Astro!

Thanks for the lightning-fast review, @egeakman! The ribbon was overlapping with the text last year, which was bugging me. That should be sorted now. I might play with tweaking it further, e.g. making it narrower, though it’s not a priority.

For the sponsor astro component, I’m not sure of the best way to handle the ribbon svg. I also lack the context for why the tier specific ribbon colours were defined in the tailwind config. But for now, I’ve separated the svg out so at least sponsor-tiers is cleaner.

Side note: I retained the filenames for now, but having multiple similar ones like sponsor-tier.astro, sponsor-tiers.astro, and sponsors.astro might get confusing. Maybe we can revisit the naming later.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments <3

I see is in draft, but just to double check that all "undefined" values should be updated before merging

@hypha hypha marked this pull request as ready for review March 6, 2025 17:38
@egeakman
Copy link
Member

egeakman commented Mar 9, 2025

I think it would be less complicated and more calling-to-action 😅 if we had something like:

10 slots left!

instead of this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants