A11y: fix card button contrast #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@hugovk thanks, but I'd prefer to keep the pink if possible, the red is too in-your-face :D maybe we can find another shade of pink we can use? |
|
Would you like to have a play with the colour picker at https://webaim.org/resources/contrastchecker/?fcolor=FFFFFF&bcolor=FF8B9D and see if there's one you like that meets WCAG AA for normal text (4.5:1)? |
patrick91
reviewed
Jul 3, 2024
Co-authored-by: Patrick Arminio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #682.
Before
The contrast ratio of white on pink is too low: 2.22: 1
After
Instead of white on pink, use white on read, like the other buttons on the front page. With #773, the ratio will be 4.53:1, above the WCAG AA minimum of 4.5.