BUGFIX: while 'elemTopBound' is decimal, the 'isInside' would be fals…

…e, and no 'ScrollLink' would be 'active'; (fisshy#112)
EverFi · Jul 21, 2016 · 2f4ff9c · 2f4ff9c
1 parent 5197aaf
commit 2f4ff9c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/build/npm/lib/mixins/Helpers.js b/build/npm/lib/mixins/Helpers.js
@@ -124,8 +124,8 @@ var Helpers = {
             }
 
             var offsetY = y - this.props.offset;
-            var isInside = (offsetY >= elemTopBound && offsetY <= elemBottomBound);
-            var isOutside = (offsetY < elemTopBound || offsetY > elemBottomBound);
+            var isInside = (offsetY >= Math.floor(elemTopBound) && offsetY <= Math.floor(elemBottomBound));
+            var isOutside = (offsetY < Math.floor(elemTopBound) || offsetY > Math.floor(elemBottomBound));
             var activeLink = scroller.getActiveLink();
 
             if (isOutside && activeLink === to) {

diff --git a/modules/mixins/Helpers.js b/modules/mixins/Helpers.js
@@ -124,8 +124,8 @@ var Helpers = {
             }
 
             var offsetY = y - this.props.offset;
-            var isInside = (offsetY >= elemTopBound && offsetY <= elemBottomBound);
-            var isOutside = (offsetY < elemTopBound || offsetY > elemBottomBound);
+            var isInside = (offsetY >= Math.floor(elemTopBound) && offsetY <= Math.floor(elemBottomBound));
+            var isOutside = (offsetY < Math.floor(elemTopBound) || offsetY > Math.floor(elemBottomBound));
             var activeLink = scroller.getActiveLink();
 
             if (isOutside && activeLink === to) {