-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Menter's 1-eq gamma transition model #1287
Draft
BumseokLee
wants to merge
22
commits into
Exawind:master
Choose a base branch
from
BumseokLee:gamma_trans
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantech
requested review from
ndevelder and
marchdf
and removed request for
psakievich
September 3, 2024 19:47
marchdf
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did a pass for esthetics really. We are chatting later this week about other things.
marchdf
reviewed
Sep 19, 2024
marchdf
reviewed
Sep 19, 2024
marchdf
reviewed
Sep 19, 2024
marchdf
reviewed
Sep 19, 2024
Ok we are getting close! Things left to do:
|
…tion model, 2) used gamma_intermittency instead of gamint in the unit test, 3) deleted some comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to begin the draft of pull request for the transition model implementation in Nalu-Wind.
This is a draft because there are still some remaining work. However, the basic function of the model is ready and I've completed validation and verification of the model for 2-D airfoils and 3-D cases. The list of the validation (and verification) is as below:
2-D cases
3-D cases
All of the validations were performed without any hard-coding. The results were compared against the experimental data as well as available other numerical results, such as NASA's OVERFLOW or FUN3D predictions.
This work did not begin from scratch but from previous work by Robert Wilson. I’ve attached some related history below.
#957
#962
He initiated the implementation, but the work wasn’t merged into the main branch due to some issues (pull/957). Additionally, some of his implementation was also reverted (pull/962) due to conflicts with other parts.
I began my work from the state of pull/962. I fixed some bugs, removed hard coding, and completely re-implemented the computation of the pressure gradient term, which is a key aspect of the current transition model and computed from several different gradients.
Currently, the transition model is only coupled to the k-omega SST model, not with hybrid RANS/LES. This is because there might be interference between the transition model and hybrid RANS/LES. On one hand, the transition model changes the characteristics of the baseline turbulence model and boundary layer. On the other hand, hybrid RANS/LES models (DES/DDES/IDDES) were developed based on fully turbulent flow assumptions with the baseline turbulence model. Therefore, there could be some undesirable interference between them. Once the current work is completed, I will investigate this.
I would like to discuss the implementation of the wall boundary condition of the model, which is the most uncertain part for me. The wall boundary condition of the transition model is zero normal flux of the intermittency (gamma). I had a meeting with Phil and asked about this but couldn't fully understand that. I also tried to check the symmetric boundary conditions in Nalu-Wind which should also have zero normal flux across the symmetric plane, it didn't work well. For this reason, I just reused what was implemented before.
This needs to be definitely double-checked, and any help or suggestions would be extremely appreciated!
We've decided to implement the overset capability of the transition model in ExaWind stack.
For a typical 3-D wind turbine case, overset exchange of intermittency between different meshes is not important, as the overset boundaries, from the wall to fringe layers, are much larger than the boundary layer thickness. However, in certain cases where there are very small gaps between solid bodies or overlapping surfaces, the oveset exchange between these Nalu-Wind meshes could become important.
Currently, TIOGA does not distinguish overset exchange between Nalu-Wind / Nalu-Wind and Nalu-Wind / AMR-Wind. Due to this, we decided to implement the overset capability of the transition model in both Nalu-Wind and AMR-wind. The capability is already implemented in Nalu-Wind. For AMR-Wind, we will implement a constant, uniform intermittency field with a value of 1 for transition simulations using the hybrid solvers, which is the freestream conditions of the transition model. Note that AMR-Wind domain is still outside of the boundary layer of the Nalu-Wind meshes and thus it doesn't need to solve the transport equation of the transition model. Therefore, for AMR-Wind, the freestream condition of the transition model will be applied in the computational domain. This implementation will be included in a separate PR of AMR-Wind.
In summary, a list of the remaining work is as below to complete the implementation of the transition model in Nalu-Wind