feat: dynamic minimum quantity #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
feat/dynamic-minimum-quantity
branch
from
7b2228e
to
0cf6ef5
Compare
ghost
marked this pull request as ready for review
ghost
changed the title
raladev
requested changes
Jan 6, 2021
There was a problem hiding this comment.
- got convertation err
2021-01-06 06:24:38.3838 [OpenDEX] trace: Base asset balance 30 (maxinbound: 0, maxoutbound: 30) and quote asset balance 2.5 (maxinbound: 2.4499095, maxoutbound: 2.45).
2021-01-06 06:24:38.3838 [OpenDEX] trace: Replacing ETH/BTC buy order with id arby-ETH/BTC-buy-order, quantity 0.36923458 and price 0.03362593
2021-01-06 06:24:38.3838 [OpenDEX] trace: Replacing ETH/BTC sell order with id arby-ETH/BTC-sell-order, quantity 0.5643896 and price 0.03465007
2021-01-06 06:24:38.3838 [OpenDEX] trace: Creating ETH/BTC sell order with id arby-ETH/BTC-sell-order, quantity 0.5643896 and price 0.03465007
2021-01-06 06:24:38.3838 [OpenDEX] trace: Creating ETH/BTC buy order with id arby-ETH/BTC-buy-order, quantity 0.36923458 and price 0.03362593
2021-01-06 06:24:38.3838 [Centralized] info: Base asset balance 0.37296423 and quote asset balance 0.01946175
2021-01-06 06:24:39.3939 [OpenDEX] warn: 2 UNKNOWN: The number 38769630.9 cannot be converted to a BigInt because it is not an integer. Retrying in 5000ms.
2021-01-06 06:24:44.4444 [Centralized] trace: New price: 0.034105
2021-01-06 06:24:44.4444 [OpenDEX] trace: Base asset balance 30 (maxinbound: 0, maxoutbound: 30) and quote asset balance 2.5 (maxinbound: 2.4499095, maxoutbound: 2.45).
2021-01-06 06:24:44.4444 [Centralized] info: Base asset balance 0.37296423 and quote asset balance 0.01946175
2021-01-06 06:24:44.4444 [OpenDEX] trace: Replacing ETH/BTC buy order with id arby-ETH/BTC-buy-order, quantity 0.36923458 and price 0.033593425
2021-01-06 06:24:44.4444 [OpenDEX] trace: Replacing ETH/BTC sell order with id arby-ETH/BTC-sell-order, quantity 0.56493571 and price 0.034616575
2021-01-06 06:24:44.4444 [OpenDEX] trace: Creating ETH/BTC buy order with id arby-ETH/BTC-buy-order, quantity 0.36923458 and price 0.033593425
2021-01-06 06:24:44.4444 [OpenDEX] warn: 2 UNKNOWN: The number 38769630.9 cannot be converted to a BigInt because it is not an integer. Retrying in 5000ms.
This is an issue with xud and fixed in ExchangeUnion/xud#2054 |
got it, changed xud of master, to xud from the branch works fine with it. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamically calculating the minimum supported CEX order quantity. Previously, the limits were hardcoded. This was causing issues because the price increase made the hardcoded limits invalid.