Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networking Guide #249

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Networking Guide #249

wants to merge 12 commits into from

Conversation

dicedpixels
Copy link
Contributor

@dicedpixels dicedpixels commented Dec 31, 2024 •
edited by its-miroma
Loading

Ports Networking.

Differences:

  • Actual working item, Lightning Tater.
  • Along with S2C, a C2S example is also included.

@netlify Netlify
Copy link

netlify bot commented Dec 31, 2024 •
edited
Loading

✅ Deploy Preview for nimble-elf-d9d491 ready!

Name Link
🔨 Latest commit 13a1e92
🔍 Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/67c1e7c91e277400082748cd
😎 Deploy Preview https://deploy-preview-249--nimble-elf-d9d491.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IMB11 IMB11 added new-content A new page or set of pages stage:verification This should be verified labels Dec 31, 2024
Octol1ttle
Octol1ttle suggested changes Dec 31, 2024
View reviewed changes
@IMB11
Copy link
Member

IMB11 commented Jan 15, 2025

Hi! The documentation has been updated to version 1.21.4. Please rebase your PR and update your code to align with the latest version.

Alternatively, you can create a new branch based on the latest commit from the FabricMC:main branch, copy over your changes from the old dicedpixels:networking branch, update it, and open a new PR - this approach is often simpler than dealing with complex git commands if you're not the best git wrangler.

Once you've completed the updates and are confident everything is ready, feel free to unmark this as a draft. Thanks again for your contribution!

@its-miroma its-miroma added stage:expansion This should be expanded and removed stage:verification This should be verified labels Jan 18, 2025
@its-miroma its-miroma mentioned this pull request Jan 29, 2025
Open
25 tasks
@its-miroma
Copy link
Member

Hello @dicedpixels, are you still working on this?

@dicedpixels
initial port of the networking tutorial
99f5d52
@dicedpixels
implement review comments:
c2279b2 
- remove dedicated data generator
- add lightning tater item model generator to the shared pack
- fix offset line numbers
- fix broken link in damage types doc
@dicedpixels
implement more review comments:
8c2ca23 
- add more info about `PlayerLookup` and adjust the code
- limt the `UseItemCallback` to the logical client
@dicedpixels
addressing another set of review comments
f73d8c2
@dicedpixels
- update code for 1.21.4
3558a67 
- attempted to improve the c2s section to align with review comments
@dicedpixels
update example videos
a5eb921
@dicedpixels
fix off set transclude
0a31c2a
@dicedpixels
add sidebar entries
a47412c
@dicedpixels
revert change in damage-types
d2edbef
@dicedpixels
Copy link
Contributor Author

Hello @dicedpixels, are you still working on this?

I guess so 😅. Haven't had time to sit and look back at it. I believe I've addressed all the comments, PR should be up-to-date. I will undraft it so more people can review.

@dicedpixels dicedpixels marked this pull request as ready for review February 26, 2025 15:29
@dicedpixels dicedpixels requested a review from a team as a code owner February 26, 2025 15:29
@its-miroma its-miroma added stage:verification This should be verified and removed stage:expansion This should be expanded labels Feb 26, 2025
its-miroma
its-miroma requested changes Feb 28, 2025
View reviewed changes
public/assets/develop/networking/sides.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really prefer if this wasn't an image as it is difficult to modify in the future...

Copy link
Contributor Author

@dicedpixels dicedpixels Feb 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, but do we have any other option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IMB11 IMB11 IMB11 requested changes

@Octol1ttle Octol1ttle Octol1ttle requested changes

@its-miroma its-miroma its-miroma requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new-content A new page or set of pages stage:verification This should be verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dicedpixels @IMB11 @its-miroma @Octol1ttle