Credits Page #280
Open
Credits Page #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its-miroma
added
needs-discussion
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
its-miroma
commented
Feb 12, 2025
its-miroma
added
stage:verification
its-miroma
force-pushed
the
team
branch
2 times, most recently
from
ee79215 to
c4bc67b
Compare
modmuss50
reviewed
Feb 25, 2025
- drop `axios` dependency - always throw if `TOKEN`s are unset - log errors to console - extract bot data logic to its own file - use bot's avatar as fallback for translators
its-miroma
commented
Mar 2, 2025
There was a problem hiding this comment.
once #293 drops I'll update it to use the Avatater
There was a problem hiding this comment.
this still needs testing as I don't have a Crowdin token
Comment on lines
+83
to
+100
| <VPTeamPageSection v-if="committers.length"> | ||
| <template #title>{{ options!.committers.title }}</template> | ||
| <template #members> | ||
| <VPTeamMembers :members="committers" size="small" /> | ||
| </template> | ||
| </VPTeamPageSection> | ||
| <VPTeamPageSection v-if="authors.length"> | ||
| <template #title>{{ options!.authors.title }}</template> | ||
| <template #members> | ||
| <VPTeamMembers :members="authors" size="small" /> | ||
| </template> | ||
| </VPTeamPageSection> | ||
| <VPTeamPageSection v-if="translators.length"> | ||
| <template #title>{{ options!.translators.title }}</template> | ||
| <template #members> | ||
| <VPTeamMembers :members="translators" size="small" /> | ||
| </template> | ||
| </VPTeamPageSection> |
There was a problem hiding this comment.
how do you prefer these to be sorted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CROWDIN_TOKENGITHUB_TOKEN