Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate error string lazily for performance. #1116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

noamkush
Copy link

@noamkush noamkush commented Mar 3, 2025

While profiling our test suite, I noticed a significant amount of time is spent in various __repr__ methods in factory_boy. Most of these calls come from Resolver.__getattr__ which uses them to generate pretty error messages. While it's nice to have user friendly error messages, this is frequently called from deepgetattr which dismisses the error immediately. Therefore, the actual string may be lazily evaluated only when necessary. This simple change significantly improves our test suite run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant