Evaluate error string lazily for performance. #1116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling our test suite, I noticed a significant amount of time is spent in various
__repr__
methods infactory_boy
. Most of these calls come fromResolver.__getattr__
which uses them to generate pretty error messages. While it's nice to have user friendly error messages, this is frequently called fromdeepgetattr
which dismisses the error immediately. Therefore, the actual string may be lazily evaluated only when necessary. This simple change significantly improves our test suite run time.