fix: Generate valid BIC/SWIFT numbers (#902) #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Im not a fan of just adding new packages to the base of Faker |
|
I see, I will refactor the test to be package agnostic. |
vjandrea
force-pushed
the
fix/902
branch
3 times, most recently
from
f1e26fa to
66660fd
Compare
- swiftBicNumber now accepts an optional $countryCode argument to localize the generated value - using Symfony Validator in tests
|
@pimjansen I removed the extra dependencies, do you mind to review please? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions. |
pimjansen
requested changes
Feb 20, 2025
| @@ -197,4 +197,20 @@ protected function getProviders(): iterable | |||
|
|
|||
| yield new PaymentProvider($this->faker); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Missing test for an invalid country code
| * @return string Swift/Bic number | ||
| */ | ||
| public static function swiftBicNumber() | ||
| public static function swiftBicNumber($countryCode = null) |
There was a problem hiding this comment.
This is a bit shady since you have no clue what can be put in here and all can be invalid. I think we have a list of all country codes already in the package. Can you use that to verify it exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Author's checklist
Summary of changes
swiftBicNumber()now returns SWIFT/BIC numbers that pass validation.Added a dev requirement for symfony/validator that might be used for other generators as well.
Review checklist
CHANGELOG.md