add SEO tags #23
add SEO tags #23
Conversation
| @@ -10,6 +10,9 @@ pub struct PageSpec { | |||
| pub redirect: Option<String>, | |||
| #[serde(skip)] | |||
| pub rendered: String, | |||
| // add struct OGStruct here | |||
| // it would have fields title, image, url, type | |||
| // | |||
There was a problem hiding this comment.
This has to be optional struct. Also for future, such approach PR could have included the commented out actual line instead of instruction.
There was a problem hiding this comment.
We also discussed a trait ToSEO with toSEOwith(&self) -> Option<SEO> default implementation (that returns None) for types implementing realm::Page.
There was a problem hiding this comment.
Also do a survey of other tags, eg there are twitter specific headers.
There was a problem hiding this comment.
Maybe we can rename this whole thing from being specific to SEO, to make it HTML Meta specific so we can overwrite favicon, css etc also.
| pub fn render(&self, is_crawler: bool) -> Result<Vec<u8>, failure::Error> { | ||
| let data = escape(serde_json::to_string_pretty(&self)?.as_str()); | ||
| let mut html = HTML_PAGE.clone(); | ||
|
|
||
| html = html.replace("__realm_title__", &self.title); | ||
| html = html.replace("__realm_title__", &self.title);// add __og_script__, use get_og_scripts function() |
There was a problem hiding this comment.
Write more commented out actual code so we know what parameters are being passed etc. Try to detail out as much without writing function bodies (tho write function body in comment form if needed).
|
@nilinswap ping. |
No description provided.