-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FHIR CI Support #120
Open
GinoCanessa
wants to merge
27
commits into
FirelyTeam:develop
Choose a base branch
from
GinoCanessa:fhir-ci
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add FHIR CI Support #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- capture some undocumented (but populated) properties - add FHIR version convenience function - add additional documentation with pointers to confluence
…ollection of servers.
Improvements to package resolution functions.
Added installation functions to FhirCiClient.
mmsmits
requested changes
Aug 27, 2024
…ue and some use a string.
… want removed content to merge with new content.
Fix: multi-server GetLatest extension was inconsistent on .Net versions.
Fix: Unit tests should download packages from build.fhir.org, even if another URL is listed as the home. Fix: Updated build date/time for FHIR 6.0 ballot 1.
mmsmits
requested changes
Sep 25, 2024
(string? branchName, bool _) = GetBranchNameRepoLiteral(qa.RepositoryUrl); | ||
|
||
// build the URL | ||
int igUrlIndex = qa.RepositoryUrl?.IndexOf("/qa.json", StringComparison.Ordinal) ?? -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a separate function
/// </summary> | ||
/// <param name="reference">The package reference.</param> | ||
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously | ||
public async Task Delete(PackageReference reference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make it async if it isn't?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to discuss.