Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FHIR CI Support #120

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Conversation

GinoCanessa
Copy link

Draft PR to discuss.

@GinoCanessa GinoCanessa marked this pull request as ready for review September 13, 2024 14:28
mmsmits and others added 3 commits September 17, 2024 10:15
Fix: Unit tests should download packages from build.fhir.org, even if another URL is listed as the home.
Fix: Updated build date/time for FHIR 6.0 ballot 1.
(string? branchName, bool _) = GetBranchNameRepoLiteral(qa.RepositoryUrl);

// build the URL
int igUrlIndex = qa.RepositoryUrl?.IndexOf("/qa.json", StringComparison.Ordinal) ?? -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a separate function

/// </summary>
/// <param name="reference">The package reference.</param>
#pragma warning disable CS1998 // Async method lacks 'await' operators and will run synchronously
public async Task Delete(PackageReference reference)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make it async if it isn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants