Count tests in progress bar #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakebi
reviewed
Apr 4, 2024
If we do not want a progress bar, we can use `ProgressBar::hidden`. Then we can still use the progress bar's position and length, even in `print_progress`.
OutOfCache
force-pushed
the
test-progress
branch
from
77c4987 to
e2a0104
Compare
OutOfCache
force-pushed
the
test-progress
branch
from
e2a0104 to
4c49b27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count tests instead of jobs.
Make the progress bar mandatory, so we can use
its position and length to keep track of the tests,
even if we do not output the bar.