-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Couchbase VectorStore] Add RecordManager #3397
base: main
Are you sure you want to change the base?
Conversation
would you be able to pull the latest changes since this PR was merged |
f4ff46a
to
d1f024f
Compare
@HenryHengZJ Done |
options: { | ||
cleanup: recordManager?.cleanup, | ||
sourceIdKey: recordManager?.sourceIdKey ?? 'source', | ||
vectorStoreName: [bucketName, scopeName, collectionName].join('_') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prajwal-pai77 @HenryHengZJ I'm wondering how to handle the vectorStoreName key for indexing, any advice ?
should we include indexName
?
Is couchbase supporting record manager from langchainJS? Have you tested it? |
I didn't test it already, but AFAIK the record manager is agnostic of the vector store, its just a DB indexing chunks states. |
Ah okay. I'll test it. There is a reason why record manager is not added to all vector stores. The addvectors and delete methods need to be able to take in ids as parameters in order to be able to use record manager. You can see the example of Qdrant that extends those functions for that |
b4d30a2
to
b99cb91
Compare
@JJK801 for some reasons i just can't seem to have Couchbase Vector Store working in order to test this, have you got any success with that? |
Hi Flowise,
This PR adds RecordManager capability to the existing Couchbase vector store node.
Related #3093