Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Couchbase VectorStore] Add RecordManager #3397

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JJK801
Copy link
Contributor

@JJK801 JJK801 commented Oct 22, 2024

Hi Flowise,

This PR adds RecordManager capability to the existing Couchbase vector store node.

Related #3093

@JJK801 JJK801 changed the title Feature/couchbase [Couchbase VectorStore] Add RecordManager Oct 22, 2024
@HenryHengZJ
Copy link
Contributor

would you be able to pull the latest changes since this PR was merged

@JJK801 JJK801 force-pushed the feature/couchbase branch 2 times, most recently from f4ff46a to d1f024f Compare October 26, 2024 06:22
@JJK801
Copy link
Contributor Author

JJK801 commented Oct 26, 2024

@HenryHengZJ Done

options: {
cleanup: recordManager?.cleanup,
sourceIdKey: recordManager?.sourceIdKey ?? 'source',
vectorStoreName: [bucketName, scopeName, collectionName].join('_')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prajwal-pai77 @HenryHengZJ I'm wondering how to handle the vectorStoreName key for indexing, any advice ?

should we include indexName ?

@HenryHengZJ
Copy link
Contributor

Is couchbase supporting record manager from langchainJS? Have you tested it?

@JJK801
Copy link
Contributor Author

JJK801 commented Oct 27, 2024

Is couchbase supporting record manager from langchainJS? Have you tested it?

I didn't test it already, but AFAIK the record manager is agnostic of the vector store, its just a DB indexing chunks states.

@HenryHengZJ
Copy link
Contributor

Is couchbase supporting record manager from langchainJS? Have you tested it?

I didn't test it already, but AFAIK the record manager is agnostic of the vector store, its just a DB indexing chunks states.

Ah okay. I'll test it. There is a reason why record manager is not added to all vector stores. The addvectors and delete methods need to be able to take in ids as parameters in order to be able to use record manager. You can see the example of Qdrant that extends those functions for that

@HenryHengZJ
Copy link
Contributor

@JJK801 for some reasons i just can't seem to have Couchbase Vector Store working in order to test this, have you got any success with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants