FEATURE: Add Setting queryParams|cookieParams.respect to invert the control
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t add cookies and arguments which affect the caching. which makes configuration much easier.
mficzel
approved these changes
Oct 18, 2023
mficzel
requested changes
Oct 18, 2023
| case (in_array($key, $this->ignoredQueryParams) && empty($this->respectedQueryParams)): | ||
| $ignoredQueryParams[$key] = $value; | ||
| break; | ||
| case (!in_array($key, $this->respectedQueryParams) && empty($this->ignoredQueryParams)): |
There was a problem hiding this comment.
I think a respected queryParameter should be added to $allowedQueryParams[$key] as i would assume this to be part of the cache identity.
That imho would also mean that allowedQueryParams should only be checked when $this->respectedQueryParams is empty.
There was a problem hiding this comment.
@mficzel How would you configure FullPageCache to not cache a search query in this case?
mficzel
changed the title
queryParams|cookieParams.respect to invert the control
|
@sbruggmann I really like this change. Have you seen the comment by Martin? Would you be willing to finish this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added new options
cookieParams.respectandqueryParams.respectwhich work the opposite way the optionscookieParams.ignoreandqueryParams.ignoredo.this way we define in the settings which cookies and arguments really matter to our code.
all others don't affect the caching.
especially with tag managers and different tracking we have a lot of changing cookies and arguments which are only meant for the frontend and should never affect the code generation and caching.
we as developers should have the option to just allow known cookies and arguments, and ignore the rest.