-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to documenter jl, + doc upgrades #88
Conversation
@darsnack could you give me some feedback here please? Once we are good with docs I could proceed with functionality |
Sorry for the delay. Will take a look later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general your mapping looks good. One global comment is to just replace the docs
directory with Documenter instead of making a new Documenter specific directory. It looks like you have the syntax mapping figured out, but there are places you missed.
For deployment, see FluxML/ParameterSchedulers.jl#58 as a reference for a similar transition. I'll take care of the admin side of Documenter deployment (keys, etc.).
I did the changes you requested. I'm not good with yml files and github deployment, so I'm gonna leave up to you. Also currently the landing page link is broken when accessed from other repos. Not sure if it's the fault of other repos or this. |
@isentropic I have added the deployment stuff. The only stuff left in this PR is all related to editing the .md files for the documentation. I've added flags to the Can you pull the latest and re-run the doc build? You'll see the warnings telling you which functions/types you need to include a docstring for. If a page exists that's an appropriate home for the missing docstring, then add it there. For example, |
yeah, done |
@darsnack any updates on this? |
I should have posted an update. I was reorganizing things locally for this PR. I will make those changes on a new PR now. Thanks for doing the lion's share of the work @isentropic! |
Moving to documnter jl as per zulip discussion
No deployment has been setup yet.