Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn on required members #589

Closed
wants to merge 6 commits into from

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Jan 16, 2025

Fixes #588

Description

See #588

The solution

Outline the implementation. Also include any alternative solutions considered.

Todos

Sorry, something went wrong.

@danielmarbach
Copy link
Contributor Author

Getting some build errors on the .NET Framework side in the PEVerifier. Unfortunately, I'm only using MacOS and Linux these days.

@SimonCropp SimonCropp added this to the 5.3.1 milestone Jan 16, 2025
@SimonCropp
Copy link
Member

@danielmarbach can i pull in my recent changes to master. i want to see if updating cecil fixes the problem

@danielmarbach danielmarbach force-pushed the required-members branch 2 times, most recently from cd6dcd6 to 64ce88b Compare January 16, 2025 16:40
@danielmarbach
Copy link
Contributor Author

I did a really base yesterday but that didn't seem to help

@SimonCropp SimonCropp closed this Feb 7, 2025
@SimonCropp
Copy link
Member

deploying a new nuget now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required members create a constructor with an Obsolete warning that leads to build errors
2 participants