Thunderbird style auto configuration #2493
Conversation
|
How about that Thunderbird auto config CardDav address book? 
|
There was a problem hiding this comment.
This looks great! I appreciate how defensively you've written the code (checking that keys exist, etc) since I imagine that these will vary / be implemented partially incorrectly by clients.
Is there a domain / set of domains you've been testing this with? I think we can ship it but it'd be nice to run it through a bunch to test it first! Our big lookup table of provider settings also comes from Thunderbird, so I think with this the autoconfig capabilities of Mailspring should largely match! Super cool.
| let smtpDetails = null; | ||
|
|
||
| // Handle IMAP | ||
| if (Array.isArray(provider.incomingServer)) { |
There was a problem hiding this comment.
I wonder if there's a case where provider could exist but provider.incomingServer (or outgoingServer) is missing? It might be nice to do an early return false in that case too.
|
I have only been testing with my own handful of domains, I am not sure of any publicly available providers that use thunderbird autoconfig. Indentation was all messed up (VS Code was being a nuisance) and I did add another check for the incoming/outgoing server |
|
Seems I was missing the dependency from However, after adding this package I then receive
|
Saw this on the feature requests some years ago, though I didn't have the skills to accomplish it at the time.
I have tried to handle every scenario, multiple providers, multiple incoming/outgoing servers, etc.