chore: more test

package.json

@@ -88,3 +88,4 @@
     "style-loader": "^0.18.2"
   }
 }
+

packages/__tests__/ReactRender.test.js

@@ -1,4 +1,5 @@
 const ReactDOM = require('../src/vdom')
+const { Component } = require('../src/component')
 const React = require('../src/Luy/index')
 const { check } = require('../testUtils')
 
@@ -11,7 +12,7 @@ describe('ReactRenderDOM', () => {
     // ReactDOM.unmountComponentAtNode(container)
   })
   it('should normal render', done => {
-    class App extends React.Component {
+    class App extends Component {
       render() {
         return (
           <div>
@@ -29,7 +30,7 @@ describe('ReactRenderDOM', () => {
   })
 
   it('should render number or text in React.Component', done => {
-    class Numberic extends React.Component {
+    class Numberic extends Component {
       render() {
         return 1
       }
@@ -43,7 +44,7 @@ describe('ReactRenderDOM', () => {
   })
 
   it('should render number in inside nested element', done => {
-    class App extends React.Component {
+    class App extends Component {
       render() {
         return <div>123</div>
       }
@@ -57,7 +58,7 @@ describe('ReactRenderDOM', () => {
   })
 
   it('should render list child component', done => {
-    class App extends React.Component {
+    class App extends Component {
       render() {
         return (
           <div>
@@ -88,4 +89,30 @@ describe('ReactRenderDOM', () => {
       done()
     })
   })
+
+  it('should render array children', done => {
+    const App = () => {
+      return [<span />, <span />, <span />, <span />]
+    }
+    ReactDOM.render(<App />, container)
+
+    check(() => {
+      expect(container.innerHTML).toEqual('<span></span><span></span><span></span><span></span>')
+      done()
+    })
+  })
+
+  it('should render children', done => {
+    class App extends Component {
+      render() {
+        return <div>{this.props.children}</div>
+      }
+    }
+    ReactDOM.render(<App>hello children</App>, container)
+
+    check(() => {
+      expect(container.innerHTML).toEqual('<div>hello children</div>')
+      done()
+    })
+  })
 })

packages/src/vdom.js

@@ -108,25 +108,15 @@ function performUnitOfWork(workInProgress) {
     //收集当前节点的effect，然后向上传递
     completeWork(current)
     if (current.sibling) return current.sibling
+    if (!current.return) {
+      // 到达最顶端了
+      pendingCommit = current
+    }
     //没有 sibling，回到这个节点的父亲，看看有没有sibling
     current = current.return
   }
 }
 
-function beginWork(currentFiber) {
-  switch (currentFiber.tag) {
-    case tag.CLASS_COMPONENT: {
-      return updateClassComponent(currentFiber)
-    }
-    case tag.FunctionalComponent: {
-      return updateFunctionalComponent(currentFiber)
-    }
-    default: {
-      return updateHostComponent(currentFiber)
-    }
-  }
-}
-
 //收集有 effecttag 的 fiber
 function completeWork(currentFiber) {
   if (currentFiber.tag === tag.CLASS_COMPONENT) {
@@ -139,9 +129,20 @@ function completeWork(currentFiber) {
     const currentEffectTag = currentFiber.effectTag ? [currentFiber] : []
     const parentEffects = currentFiber.return.effects || []
     currentFiber.return.effects = parentEffects.concat(currentEffect, currentEffectTag)
-  } else {
-    // 到达最顶端了
-    pendingCommit = currentFiber
+  }
+}
+
+function beginWork(currentFiber) {
+  switch (currentFiber.tag) {
+    case tag.CLASS_COMPONENT: {
+      return updateClassComponent(currentFiber)
+    }
+    case tag.FunctionalComponent: {
+      return updateFunctionalComponent(currentFiber)
+    }
+    default: {
+      return updateHostComponent(currentFiber)
+    }
   }
 }
 
@@ -254,6 +255,7 @@ function placeChild(currentFiber, newChild) {
   }
 
   if (typeof type === 'function') {
+    // 可能有两种
     const _tag = type.prototype.isReactComponent ? tag.CLASS_COMPONENT : tag.FunctionalComponent
 
     return {