Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abi - Refactor / Gen #3032

Closed
3 tasks
arboleya opened this issue Aug 25, 2024 · 2 comments · May be fixed by #3085
Closed
3 tasks

Abi - Refactor / Gen #3032

arboleya opened this issue Aug 25, 2024 · 2 comments · May be fixed by #3085
Assignees
@nedsalk
Labels
chore Issue is a chore feat Issue is a feature

Comments

@arboleya
Copy link
Member

  • Refactor and move abi-typegen into it
  • Plug existent strategies with abi/parser public interface
  • Prepare the foundation for multiple output format (Javascript)
@arboleya arboleya added feat Issue is a feature chore Issue is a chore labels Aug 25, 2024
@arboleya arboleya added this to the Caterpillar v1 milestone Aug 25, 2024
@petertonysmith94
Copy link
Contributor

We should rethink the need for the Vec helper type as it's essentially the same as Array<T> or T[].

Originally posted by @nedsalk in #3046 (comment)

This was referenced Sep 2, 2024
Merged
Draft
@arboleya arboleya mentioned this issue Sep 7, 2024
Closed
@arboleya arboleya removed this from the Caterpillar v1 milestone Sep 7, 2024
@arboleya arboleya added the temp:notion label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
@arboleya arboleya added the temp-linear label Sep 8, 2024 — with Linear
@arboleya arboleya mentioned this issue Sep 9, 2024
Closed
@nedsalk nedsalk mentioned this issue Sep 9, 2024
Merged
4 tasks
@petertonysmith94
Copy link
Contributor

  • We will move the static storageSlots variable from the Contract (e.g. MyTypegenContract.storageSlots) to the Factory (e.g. MyTypegenContractFactory.storageSlots). As it is only relevant for deployment purposes.
  • This is a breaking change, so we should make note on the relevant PR of this.

@petertonysmith94 petertonysmith94 mentioned this issue Sep 16, 2024
Merged
4 tasks
@nedsalk nedsalk mentioned this issue Sep 18, 2024
Open
@petertonysmith94 petertonysmith94 mentioned this issue Oct 4, 2024
Draft
4 tasks
@danielbate danielbate mentioned this issue Nov 6, 2024
Closed
@danielbate danielbate closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@danielbate danielbate mentioned this issue Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nedsalk nedsalk

Labels
chore Issue is a chore feat Issue is a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ABI refactor FuelLabs/fuels-ts
4 participants
@arboleya @danielbate @petertonysmith94 @nedsalk