Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ABI refactor #3085

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

feat: ABI refactor #3085

wants to merge 21 commits into from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 3, 2024

Closes TS-598, TS-599, TS-600
Part of TS-597, TS-601

Release notes

In this release, we:

  • A brand new package @fuel-ts/abi for all things ABI related

Summary

Note

TBD

Breaking Changes

Note

TBD

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 8:47am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 8:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 17, 2024 8:47am

---
---

feat: ABI refactor
Copy link
Contributor Author

@petertonysmith94 petertonysmith94 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This is not to be merged until we've concluded development

@petertonysmith94 petertonysmith94 added this to the Caterpillar v1 milestone Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage Report:

Lines Branches Functions Statements
79.26%(+0%) 71.93%(+0%) 77.55%(+0%) 79.33%(+0%)
Changed Files:

Coverage values did not change👌.

* add matchers and PoC

* add "full" flow

* extract relevant regexes into variables

* update generics

* fix tupleRegex

* Update sway-type-matchers.ts

* refactor out parameterized tests

* add test tags

* Update packages/abi/src/matchers/sway-type-matchers.ts

Co-authored-by: Peter Smith <[email protected]>

* add `createMatcher` utility

* remove typers and coders

* remove irrelevant changes

* fix test

* rename `empty` to `void`

* Update packages/abi/src/matchers/sway-type-matchers.ts

Co-authored-by: Anderson Arboleya <[email protected]>

* fix compilation

---------

Co-authored-by: Peter Smith <[email protected]>
Co-authored-by: Anderson Arboleya <[email protected]>
Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #3085 will improve performances by ×2.5

Comparing np/feat/abi-refactor (7e3b66c) with master (3668a26)

Summary

⚡ 1 improvements
✅ 20 untouched benchmarks

Benchmarks breakdown

Benchmark master np/feat/abi-refactor Change
Instantiate a new Unlocked wallet 103.3 ms 40.5 ms ×2.5

* chore: consolidated all ABI Sway programs

* chore: added missing `abi-library`

* Update packages/fuel-gauge/test/fixtures/forc-projects/abi-contract/Forc.toml
petertonysmith94 and others added 6 commits September 17, 2024 10:42
* test `reportUserVersion`

* move util to `versions` package

* export via cli and not index

* log fuels version

* fetch latest version

* log out comparison

* add changeset

* fix tests

* disable pr release

* add tests

* re-use `getBuiltinVersions`

* move to `fuels` CLI from `versions`

* revert test changes

* revert tests

* add tests

* add testing group

* add changeset

* add a test case

* print a msg if fetch fails

* add error msg in one more place

* fix test

---------

Co-authored-by: Chad Nehemiah <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Peter Smith <[email protected]>
Co-authored-by: Chad Nehemiah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abi - Refactor / Gen Abi - Refactor / Coder Abi - Refactor / Parser
6 participants