Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added error code expectations to the exhaustive examples #3135

Merged
merged 4 commits into from
Sep 9, 2024
Merged

chore: added error code expectations to the exhaustive examples #3135

merged 4 commits into from
Sep 9, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Sep 9, 2024 •
edited
Loading

Summary

  • Added error code expectations to the exhaustive examples.
  • Document the current error codes + messages, therefore, enabling improvement within Abi - Refactor / Coder #3031.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Sep 9, 2024
@petertonysmith94 petertonysmith94 self-assigned this Sep 9, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:21am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:21am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 9, 2024 11:21am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.15%(+0%) 77.73%(+0%) 79.44%(+0%)
Changed Files:

Coverage values did not change👌.

@petertonysmith94 petertonysmith94 marked this pull request as ready for review September 9, 2024 15:45
@petertonysmith94 petertonysmith94 merged commit 65f3e04 into master Sep 9, 2024
29 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/added-expectations-on-error-codes branch September 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arboleya arboleya arboleya approved these changes

@maschad maschad maschad approved these changes

@nedsalk nedsalk nedsalk approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petertonysmith94 @arboleya @maschad @nedsalk @Torres-ssf