Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): branch protection improvements #58

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

Aaron-Ritter
Copy link
Collaborator

@Aaron-Ritter Aaron-Ritter commented Mar 19, 2025

This adds multiple release workflow improvements:

  • Move workflows to PR checks.
  • Update workflow triggers and documentation.
  • Add RELEASE_WORKFLOW_TOKEN to release-please-action.
  • Updated extra-files structure in prerelease- and release-config.
  • Added .github/prerelease-manifest.json with a JSON path specification to release-config for release-please to handle the version syncing.
    • Removed workflow steps for syncing and committing the prerelease manifest files.
    • This simplifies the release process and avoids branch protection workarounds.

I’ve tested the workflow in https://github.com/sonderformat-llc/release-please-prerelease-example including branch protection rules.

- the checks will run once the PR is created as a required check
- in order for the PR to run the required checks
- the steps would require permission to push in to main but this is not possible because of branch protection
- to avoid it all together we add it in the release PR instead
@johnjeffers johnjeffers merged commit d16a220 into main Mar 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants