Implemented PaperQAEnvironment.from_task
#907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
sremo,
mskarlin,
maykcaldas,
ludomitch,
JoaquinPolonuer and
Copilot
dosubot
bot
added
the
size:M
jamesbraza
changed the title
PaperQAEnvironment.from_taskPaperQAEnvironment.from_task
There was a problem hiding this comment.
PR Overview
This PR implements the missing from_task class method for PaperQAEnvironment and adds tests to ensure that environments can be created by name.
- Updated import style in tests for clarity.
- Added from_task class method to PaperQAEnvironment.
- Registered the PaperQAEnvironment in ENV_REGISTRY.
Reviewed Changes
| File | Description |
|---|---|
| tests/test_agents.py | Added tests verifying that "paperqa" is available and instantiates PaperQAEnvironment. |
| paperqa/agents/env.py | Introduced the from_task class method and registered PaperQAEnvironment in ENV_REGISTRY. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
whitead
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized I forgot to do this