-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for answer iterations in the gen_answer flow #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for answer iterations in the gen_answer flow so that a prior answer can be employed when a user follows up on a query. Key changes include:
- Updating tests to verify that both initial queries and queries with a prior answer are handled correctly.
- Adding new iteration prompts in prompts.py to instruct the model on how to build on a previous answer.
- Updating settings and prompt configuration to include iteration-related defaults and validations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/test_paperqa.py | Added tests to validate query behavior when a prior answer is provided. |
paperqa/prompts.py | Introduced new prompts for answer iterations. |
paperqa/docs.py | Updated query logic to insert iteration context into the prompt. |
paperqa/settings.py | Added iteration-related settings and a field validator for the new prompt. |
jamesbraza
reviewed
Mar 12, 2025
nadolskit
reviewed
Mar 12, 2025
nadolskit
approved these changes
Mar 12, 2025
jamesbraza
reviewed
Mar 12, 2025
jamesbraza
approved these changes
Mar 12, 2025
sremo
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are answering after a prior answer already exists in the session, we currently don't expose that to the
gen_answer
tool /aquery
. To support continuations, where a user follows up to a query, exposing the prior answer if very helpful (because the agent can't pass it directly), so this implements that feature.