Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for answer iterations in the gen_answer flow #911

Merged
merged 6 commits into from
Mar 12, 2025

Conversation

mskarlin
Copy link
Collaborator

If we are answering after a prior answer already exists in the session, we currently don't expose that to the gen_answer tool / aquery. To support continuations, where a user follows up to a query, exposing the prior answer if very helpful (because the agent can't pass it directly), so this implements that feature.

@mskarlin mskarlin requested review from jamesbraza, maykcaldas, a team and Copilot March 12, 2025 20:18
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for answer iterations in the gen_answer flow so that a prior answer can be employed when a user follows up on a query. Key changes include:

  • Updating tests to verify that both initial queries and queries with a prior answer are handled correctly.
  • Adding new iteration prompts in prompts.py to instruct the model on how to build on a previous answer.
  • Updating settings and prompt configuration to include iteration-related defaults and validations.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_paperqa.py Added tests to validate query behavior when a prior answer is provided.
paperqa/prompts.py Introduced new prompts for answer iterations.
paperqa/docs.py Updated query logic to insert iteration context into the prompt.
paperqa/settings.py Added iteration-related settings and a field validator for the new prompt.
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
@mskarlin mskarlin merged commit 8501bc8 into main Mar 12, 2025
3 of 5 checks passed
@mskarlin mskarlin deleted the allow-answer-iterations branch March 12, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants