Only show the top contexts to the agent for the specific question #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that only the top contexts for the currently asked question are shown to the agent when evidence is gathered. Key changes include:
- Updating the test to use a new question for evidence gathering and verifying that only relevant contexts are returned.
- Adding a question field to the Context model in paperqa/types.py.
- Filtering contexts by question in the evidence gathering tool to return only the top relevant ones.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_agents.py | Updated the test to use a new question and verify evidence filtering |
| paperqa/types.py | Added and propagated the “question” field for context differentiation |
| paperqa/agents/tools.py | Updated filtering logic in gather_evidence to filter contexts by question |
| paperqa/core.py | Passed the question value to the Context constructor |
maykcaldas
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
There's this test which uses Context and question is not set.
Specifically for the test, it doesn't matter. But do we want to add the question to the context just to be consistent?
Besides that, it lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple gather evidence iterations are performed in a question, the agent sees the top contexts for all submitted questions currently. We should only show the agent the top contexts for the particular question being asked of gather_evidence at that time. This PR fixes that and adds a test.