Java/http api #676
Open
Java/http api #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e its async implementation does not support inputstreams but java async http does
…get the captured content in my test, fantastic
doxthree
requested review from
GermanCoding,
lennartdohmann,
pstadermann and
unglaublicherdude
pstadermann
requested changes
Jan 8, 2025
java/src/main/java/de/gdata/vaas/ClientCredentialsGrantAuthenticator.java
Outdated
Show resolved
Hide resolved
java/src/main/java/de/gdata/vaas/ResourceOwnerPasswordGrantAuthenticator.java
Outdated
Show resolved
Hide resolved
|
|
||
| return forSha256(sha256, forSha256Options) | ||
| .thenCompose(handleException(vaasVerdict -> { | ||
| var verdictWithoutDetection = vaasVerdict.getVerdict() == Verdict.MALICIOUS |
There was a problem hiding this comment.
This and the following if are strange. Please compare to golang.
There was a problem hiding this comment.
This part is inspired by the csharp implementation. When requesting forSha256, two cases can happen:
- Cached Sha256 with detection, mimetype, etc.
- Hashlookup without detection
This condition is for case 1
pstadermann
reviewed
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.