Preserve the order of flattened properties. #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `#[serde(flatten)]` in combination with the `preserve_order` feature, Schemars did not actually preserve the order; flattened properites would always be inserted last. This change modifies the derive macro to insert flattened properties as they come.
SamirTalwar
force-pushed
the
preserve-order-when-flattening
branch
from
a8f3591 to
6028136
Compare
|
Closing this PR as this is fixed in schemars v1.0.0-alpha.3, according to #122 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #122.
When using
#[serde(flatten)]in combination with thepreserve_orderfeature, Schemars did not actually preserve the order; flattened properites would always be inserted last.This change modifies the derive macro to insert flattened properties as they come.
I haven't added test cases as there don't seem to be any for
preserve_orderand I'm not sure how to go about doing this. However, I did add a flattened structure to theserde_attrsexample, and tested it manually.