Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSRProvider issue on React 18+ #5788

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lev-Shapiro
Copy link

Summary

I've just started using React Native and chose NativeBase as UI library, however it seems that it has bug for the version 18+ of React, which couple people mentioned in Issues and even made PRs, however they were closed for some unknown reason and the error is still there, so I've made this pull request in order to solve the SSRProvider bug ( terminal: WARN In React 18, SSRProvider is not necessary and is a noop. You can remove it from your app. )

@auto-assign auto-assign bot requested a review from surajahmed October 5, 2023 19:39
@vercel
Copy link

vercel bot commented Oct 5, 2023

Someone is attempting to deploy a commit to the Geekyants Team Team on Vercel.

A member of the Team first needs to authorize it.

@Lev-Shapiro
Copy link
Author

Lev-Shapiro commented Oct 5, 2023

Inspired to do this PR, by: #5788, #5764 and #5778

@jetonk
Copy link

jetonk commented Jan 24, 2024

@Lev-Shapiro After I applied the changes into src/core/NativeBaseProvider.tsx same as in your PR, it looks it doesn't want to work.

Screenshot 2024-01-24 at 12 22 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants