Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeqRepoAccess should support SeqRepoRESTDataProxy #307

Open
korikuzma opened this issue Jul 5, 2024 · 1 comment
Open

SeqRepoAccess should support SeqRepoRESTDataProxy #307

korikuzma opened this issue Jul 5, 2024 · 1 comment
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@korikuzma
Copy link
Member

Feature description

Currently, SeqRepoAccess inherits from SeqRepoDataProxy (local). I think we should extend support for SeqRepoRESTDataProxy.

Use case

We're currently limited to using local SeqRepo. It would be nice to be able to have the option to use the REST dp

Proposed solution

SeqRepoAccess should inherit _DataProxy

Alternatives considered

No response

Implementation details

No response

Potential Impact

Provides more flexibility. We could also leverage REST for CI tests

Additional context

No response

Contribution

None
@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Jul 5, 2024
@jsstevenson
Copy link
Member

👍 on this. SeqRepo uses a basic factory method to dispatch out to local vs REST proxies based on the structure of the URI, so we'll presumably need to do something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsstevenson @korikuzma