Use UIFontMetrics to scale fonts #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS 11 and up, use UIFontMetrics to scale font sizes. Falls back to a calculation using the current content size category / large as a multiplier. Also adds the `scalingTextStyle` attribute to `TextStyle` with a default value of `body` so that users may specify how they'd prefer to scale the specific font. This should not be a breaking change for anyone since it's an added field with a default value. All tests still pass without adding this new value anywhere.
|
This is so great, TIL! Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw your comment about the article I wrote in #52 and figured I had to take a quick stab at fixing that for you. 😄 Let me know if you'd like to see more tests, you can come up with a nicer name than
scalingTextStyle, or if there is any documentation I should update.On iOS 11 and up, use UIFontMetrics to scale font sizes. Falls back to
a calculation using the current content size category / large as a
multiplier.
Also adds the
scalingTextStyleattribute toTextStylewith a defaultvalue of
bodyso that users may specify how they'd prefer to scale thespecific font.
This should not be a breaking change for anyone since it's an added
field with a default value. All tests still pass without adding this new
value anywhere.