Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: formatting #47

Merged
merged 36 commits into from
May 2, 2024
Merged

feat: formatting #47

merged 36 commits into from
May 2, 2024

Conversation

Gnarus-G
Copy link
Owner

@Gnarus-G Gnarus-G commented Sep 28, 2023

accidentally merged #42

ever - realized this will be more complicated than I thought if I want
to respect line column maximums
@Gnarus-G Gnarus-G changed the title feat: basic proof of concept, this will have to be the dumbest formatter feat: formatting Sep 28, 2023
@Gnarus-G Gnarus-G self-assigned this Apr 27, 2024
@Gnarus-G Gnarus-G added the enhancement New feature or request label Apr 27, 2024
@Gnarus-G
Copy link
Owner Author

So. The fact that empty ${} in template strings disappear through the lexer is fine, because `${}` and "" (an empty string) are equivalent.

@Gnarus-G
Copy link
Owner Author

Gnarus-G commented Apr 29, 2024

Will refactor the template literal parsing after all. We lose too much information. `${"asdfasdf"}` != `"asdfasdf"` yet the formatter can only assume otherwise because the lexer is too dumb.

@Gnarus-G Gnarus-G merged commit 3b0e6fc into main May 2, 2024
1 check passed
@Gnarus-G Gnarus-G deleted the feat/format branch June 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant