tests: add more screenshot tests #1713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
jrandolf/screenshots
branch
6 times, most recently
from
f34365b
to
d9db826
Compare
|
Looks like tests fail |
jrandolf-2
force-pushed
the
jrandolf/screenshots
branch
5 times, most recently
from
098a8a2
to
8b2e2af
Compare
OrKoN
requested changes
Jan 18, 2024
| @@ -771,12 +771,12 @@ export class BrowsingContextImpl { | |||
| switch (params.origin) { | |||
| case 'document': { | |||
| script = String(() => { | |||
| const element = document.documentElement; | |||
| const rect = document.body.getBoundingClientRect(); | |||
There was a problem hiding this comment.
Would not it make the problem worse meaning given that the body can be made of size 0x0 while the content is still visible?
There was a problem hiding this comment.
Yea, that's a good argument.
jrandolf-2
force-pushed
the
jrandolf/screenshots
branch
from
8b2e2af
to
0e33fed
Compare
|
@sadym-chromium assert_screenshot looks useful, let's revert the mapper changes though. WDYT? |
agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a screenshot fixture and adds more test.