New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add filtering feedback to the matrix #803

Draft

mayan-000 wants to merge 3 commits into develop from feat/highlight-filter-matrix

Collaborator

mayan-000 commented Aug 14, 2024 •

edited

Loading

Description

This PR adds code to apply styles conditionally to the matrix components when filters are selected.

Relevant Technical Choices

Expose a new method isFilterValueSelected to check whether the value is selected.
The boolean return then shows the bg color to matrix components.

Testing Instructions

Open PSAT's cookie landing page, and select filters.
The selection should highlight the bg of the matrix component.
Try the same with the CLI dashboard.

Additional Information:

Screenshot/Screencast

Screenshot 2024-08-14 at 15 41 40

Screenshot 2024-08-14 at 15 42 12

Checklist

I have thoroughly tested this code to the best of my abilities.
I have reviewed the code myself before requesting a review.
~~This code is covered by unit tests to verify that it works as intended.~~
The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #800

mayan-000 added 3 commits

August 14, 2024 13:31


          Add callbacks to handle is filter selected

346f830


          Add callbacks to handle is filter selected to dashboard

a3ad2de


          Update callback args

e30dd3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet