Add dummy value for Jetty 9 logging system property when using Jetty 12. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
-- 845d97f by Lachlan Roberts <[email protected]>: Add dummy value for Jetty 9 logging system property when using Jetty 12. Signed-off-by: Lachlan Roberts <[email protected]> COPYBARA_INTEGRATE_REVIEW=#100 from GoogleCloudPlatform:fix-jetty12-logging-property 845d97f PiperOrigin-RevId: 615280309 Change-Id: If4494705a666235b0b30b50aec7dadfbce3a8645
srinjoyray
pushed a commit
that referenced
this pull request
Nov 12, 2024
-- 845d97f by Lachlan Roberts <[email protected]>: Add dummy value for Jetty 9 logging system property when using Jetty 12. Signed-off-by: Lachlan Roberts <[email protected]> COPYBARA_INTEGRATE_REVIEW=#100 from GoogleCloudPlatform:fix-jetty12-logging-property 845d97f PiperOrigin-RevId: 615280309 Change-Id: If4494705a666235b0b30b50aec7dadfbce3a8645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see jetty/jetty.project#11499
The code in https://github.com/googleapis/google-auth-library-java/blob/main/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java#L321 is checking the
org.eclipse.jetty.util.log.classsystem property to determine whether it is on GAE Standard 7. But this system property was not set for Jetty 12 because we use the SLF4J to JUL bridge.If we set this property to a dummy value we can make Jetty 12 work better with
google-auth-library-java.I experienced this issue when trying to use
google-cloud-logging-logbackfor google cloud logging with logback on the Java21 runtime. And got errors saying:I have tested the logging after this change and it works without any errors.