Skip to content

Commit

Permalink
Disabling gRPC test temporarily (#1929)
Browse files Browse the repository at this point in the history
* Disabling the grpc test

* Disabling grpc in the periodic tests

* review comments

* skipping the grpc test in louhi pipeline
  • Loading branch information
raj-prince authored May 17, 2024
1 parent 8312967 commit e12cd0e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
set -e

readonly RUN_E2E_TESTS_ON_INSTALLED_PACKAGE=true
readonly SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE=true

cd "${KOKORO_ARTIFACTS_DIR}/github/gcsfuse"
echo "Building and installing gcsfuse..."
Expand All @@ -30,4 +31,4 @@ git checkout $commitId

echo "Running e2e tests on installed package...."
# $1 argument is refering to value of testInstalledPackage
./tools/integration_tests/run_e2e_tests.sh $RUN_E2E_TESTS_ON_INSTALLED_PACKAGE
./tools/integration_tests/run_e2e_tests.sh $RUN_E2E_TESTS_ON_INSTALLED_PACKAGE $SKIP_NON_ESSENTIAL_TESTS_ON_PACKAGE
2 changes: 1 addition & 1 deletion tools/cd_scripts/e2e_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ git checkout $(sed -n 2p ~/details.txt) |& tee -a ~/logs.txt
#run tests with testbucket flag
set +e
GODEBUG=asyncpreemptoff=1 CGO_ENABLED=0 go test ./tools/integration_tests/... -p 1 --integrationTest -v --testbucket=$(sed -n 3p ~/details.txt) --testInstalledPackage --timeout=60m &>> ~/logs.txt
GODEBUG=asyncpreemptoff=1 CGO_ENABLED=0 go test ./tools/integration_tests/... -p 1 -short --integrationTest -v --testbucket=$(sed -n 3p ~/details.txt) --testInstalledPackage --timeout=60m &>> ~/logs.txt
if [ $? -ne 0 ];
then
Expand Down
10 changes: 6 additions & 4 deletions tools/integration_tests/implicit_dir/implicit_dir_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,13 @@ func TestMain(m *testing.M) {
log.Fatalf("client.CreateStorageClient: %v", err)
}

flags := [][]string{
{"--implicit-dirs"},
{"--client-protocol=grpc", "--implicit-dirs=true"}}
flagsSet := [][]string{{"--implicit-dirs"}}

successCode := implicit_and_explicit_dir_setup.RunTestsForImplicitDirAndExplicitDir(flags, m)
if !testing.Short() {
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=true"})
}

successCode := implicit_and_explicit_dir_setup.RunTestsForImplicitDirAndExplicitDir(flagsSet, m)

// Close storage client and release resources.
storageClient.Close()
Expand Down
5 changes: 2 additions & 3 deletions tools/integration_tests/operations/operations_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,10 @@ func TestMain(m *testing.M) {
// By default, creating emptyFile is disabled.
{"--implicit-dirs=true"},
{"--implicit-dirs=false"},
{"--experimental-enable-json-read=true", "--implicit-dirs=true"},
{"--client-protocol=grpc", "--implicit-dirs=true"}}
{"--experimental-enable-json-read=true", "--implicit-dirs=true"}}

if !testing.Short() {
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=false"})
flagsSet = append(flagsSet, []string{"--client-protocol=grpc", "--implicit-dirs=true"})
}

mountConfigFlags := createMountConfigsAndEquivalentFlags()
Expand Down

0 comments on commit e12cd0e

Please sign in to comment.